Author | Post | |||
moose |
I just corrected the castling-implementation. Thanks aceldama! edit: I did some more code refactoring (knights and kings move) and added the first client (PHP). Its a very simple client. I think some JavaScript could make it much simpler to use. |
|||
Edited by moose on 14.08.2011 08:51:40 | ||||
13.08.2011 13:39:56 |
|
|||
aceldama |
i ran into another snag. XD for us winblows users out there, the files in the figures directory have a syntactical ambiguity. B=b and so on. might i suggest a small name-change for these? b and bb perhaps? (bishop, bishop black) |
|||
14.08.2011 17:13:24 |
|
|||
moose |
huh? B = b on Windows? I can't understand this. Aren't file names on Windows case sensitive? Or did I missunderstand you? |
|||
14.08.2011 18:00:25 |
|
|||
aceldama |
no, they're case insensitive on windows. that's something i've always found a bit annoying. EDIT: also, see the suggested changes to your client - http://code.google.com/p/community-chess/issues/list (number 2, as i messed up the first post - there was no changes to the initial file) |
|||
Edited by aceldama on 14.08.2011 18:16:20 | ||||
14.08.2011 18:02:02 |
|
|||
moose |
I'm sorry, I still don't understand. You added this to displayField($figure, $x, $y, $server): /* Just some error prevention */ if($figure==""){ $figure="0"; } elseif(strtolower($figure)!=$figure){ //Discern black from white pieces for windows servers $figure .= "b"; } How could possibly be $figure empty? If windows has case sensitive files, why do you need to add "b"? |
|||
14.08.2011 18:22:24 |
|
|||
aceldama |
figure is empty when person is not logged in, resulting in lots of ugly broken image icons. |
|||
14.08.2011 18:32:48 |
|
|||
aceldama |
and windows is case INsensitive. |
|||
14.08.2011 18:33:23 |
|
|||
moose |
Ah, now I understand. Thanks (by the way, I've just asked on stackoverflow what happens when a case-insensitive client contacts and webserver?. Just in case someone might be interested in the answer.) I changed the filenames locally. Should I credit you with your real name or with aceldama (in the Changelog and README)? I'll commit the changes as soon as you answer. |
|||
Edited by moose on 14.08.2011 19:37:00 | ||||
14.08.2011 19:33:03 |
|
|||
aceldama |
you can use which ever name you like, as long as you don't use both. i don't particularly want them to show up together on a web-search. there may be undesired consequences. lol. um, if a windows client contacts a linux server, the server would dish up the right files. the problem comes in when the script is hosted on a case-insensitive client. then, no matter what you request, you'll only end up with the same files. basically, you can't create two files of the same name in the same directory, so you see where the problem comes in. in my case, i'm running it on windows, so i can't have both black and white images in the same directory if the naming stayed the way it was. (sounds so much more complicated than it really is.) |
|||
Edited by aceldama on 14.08.2011 19:55:45 | ||||
14.08.2011 19:49:15 |
|
|||
moose |
Ok, so I will keep using aceldama as I already wrote your username in the README. The bug is fixed in r67. |
|||
14.08.2011 19:57:39 |
|